docs: add product/technical gap baseline - #41
Conversation
Grounds the current PR/issue queue, the RankWeave-LineageWeave reuse-boundary verification from this session (one-directional dependency, healthy contract, no orphaned cross-repo work item currently exists), a PRD/TRD-lite capability inventory, and a prioritized buyer-facing gap analysis in one file that stays in sync with gh pr/issue state instead of drifting from it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRankWeave에 Rust 계산 코어와 PyO3 확장을 추가했다. semantic-unit cosine ranking과 immutable exact semantic index를 구현했다. Maturin 패키징, native wheel 릴리스, 아카이브 검증, Rust CI 및 오프라인 검증 환경을 갱신했다. ChangesRust 계산 코어와 semantic index
패키징과 릴리스 검증
제품 계약과 기술 문서
Estimated code review effort: 5 (Critical) | ~120 minutes Merge Risk: 🟡 Moderate · up to The current head introduces native ranking APIs and release-pipeline changes in addition to documentation. It still has concrete merge-readiness risks, including validation against the wrong native artifact, unpinned release toolchains, incomplete artifact checks, and caller-controlled authorization scope; merge should wait for fixes or explicit owner acceptance. Sequence Diagram(s)sequenceDiagram
participant Consumer
participant SemanticUnitExactIndex
participant RustCore
participant PythonReport
Consumer->>SemanticUnitExactIndex: provide snapshot and authorized identities
SemanticUnitExactIndex->>RustCore: validate packed authorization and query batch
RustCore->>RustCore: compute exact deterministic cosine scores
RustCore-->>SemanticUnitExactIndex: return per-query reports and digests
SemanticUnitExactIndex-->>PythonReport: convert native tuples to typed reports
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 42.21% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 154 functions across 21 files. (5 skipped: 5 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The required Strix Security Scan on this head failed with "gh: API rate limit exceeded for installation ID 141441800" — a shared GitHub App installation token contended by concurrent org automation, not a finding in this diff (docs-only change). Empty commit to force a fresh dispatch on unchanged content. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Addresses Devin review feedback on PR #41: "six versions of shipped capability" implied a sequential version count that doesn't hold between 0.1.0 and 0.18.0. Restate the gap directly instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Update the PR/issue evidence table now that PR #40/#36/#41 have zero unresolved threads and all-green checks, and record the actual remaining blocker discovered live: ContextualWisdomLab/.github's org-queue-sweep enforces one OpenCode review dispatch per 15-minute tick shared across the whole organization, not per repository. Filed as ContextualWisdomLab/.github#1219 with evidence rather than patching a shared, cost-relevant throttle blind. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Naruon pins PyPI 0.1.0; LineageWeave pins a git commit for post-0.1.0 APIs. Neither consumer has a written contract for what upgrade is safe. Freeze rankweave.__all__ as of 0.18.0: no removal or rename within a minor version, enforced by tests/test_public_api_compatibility.py rather than left as an unchecked policy statement (docs/product-technical-gap-baseline.md §6 gap 2). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…tatus The evidence table was missing PR #42 (opened later in the same session that authored this document) and the org-wide review-dispatch bottleneck section still only referenced the original issue filing, not the three mitigations that have since merged (#1220, #1221, #1226) or the fourth one still pending (#1245). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
CodeRabbit's review on the previous push (b09b513) found five real issues: a fabricated Samuel et al. (2025) citation (wrong authors/title/venue — replaced with the correct, already-verified MMMORRF citation used in docs/research/README.md), a self-refuting "zero LineageWeave references in the tree" claim now that this document itself references LineageWeave extensively, a §8 scope note claiming citations live only in §6 when they actually live in §3 and §4, and inconsistent update-trigger wording between the intro and the Maintenance section. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headb7b63df3c09b68b627c8e17a060a55a5edc18351. -
Head SHA:
b7b63df3c09b68b627c8e17a060a55a5edc18351 -
Workflow run: 32702757278
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: product-technical-gap-baseline.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: product-technical-gap-baseline.md"]
R1 --> V1["docs review"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Docs: product-technical-gap-baseline.md"]
S1 --> I1["operator or user guidance"]
I1 --> R1["Review risk: Docs: product-technical-gap-baseline.md"]
R1 --> V1["docs review"]
|
Same central-infra artifact as PR #40/#36 (dismissed ~15:xx UTC, same wave): coverage-evidence run 32702757278 (ContextualWisdomLab/.github#1127) failed with "Required uv version ==0.11.29 does not match the running version 0.12.1" -- tracked at ContextualWisdomLab/.github#1234, now with a third confirmed occurrence in the same dispatch wave. RankWeave own coverage-evidence check on this same head (b7b63df) passes: 661 tests, 100% coverage. Dismissing the stale review; PR diff is unaffected.
|
Exact-head product-contract update at
Evidence: Ruff passed; 661 tests passed; statement and branch coverage are 100%; |
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me> Signed-off-by: Seongho Bae <seonghobae@users.noreply.github.com>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
| "SemanticUnitCandidate", | ||
| "SemanticIndexRankingReport", | ||
| "SemanticIndexSnapshotEvidence", | ||
| "SemanticUnitExactIndex", | ||
| "SemanticUnitRank", | ||
| "SemanticUnitRankingReport", |
Signed-off-by: Seongho Bae <me@seonghobae.me>
| #[cfg(target_os = "macos")] | ||
| absolute_normalized_vectors: Vec<f64>, |
Summary
Adds
docs/product-technical-gap-baseline.md, the standing gap-baselinedocument tracking:
(evidence table, not aspiration).
session: dependency direction is one-way (LineageWeave depends on
RankWeave via a pinned commit, currently matching
mainexactly), thefail-closed contract (LineageWeave ADR 0024, Cormack et al. 2009 η=60,
Samuel et al. 2025 unequal-channel weights) is intact, and no orphaned
cross-repo work item currently exists on either side.
API-compatibility policy; workflow-identity lifecycle has no self-cleaning
step; central PR-repair scheduler reachability; the org-wide Rust/GPU and
multilevel/temporal-modeling mandates evaluated against this repo's actual
workload and explicitly not applied where they don't fit, with reasoning
recorded instead of silently skipped or blindly applied).
Test plan
python -m ruff check .— cleanpython -m coverage run -m pytest -q && python -m coverage report— 661passed, 100% statement and branch coverage (docs-only change; no production
code touched)
Summary by CodeRabbit
새 기능
버그 수정
문서화